Cast to same type¶
ID: cs/useless-cast-to-self
Kind: problem
Security severity:
Severity: warning
Precision: medium
Tags:
- maintainability
- language-features
- external/cwe/cwe-561
Query suites:
- csharp-security-and-quality.qls
Click to see the query in the CodeQL repository
Casting an expression to the type that it already has serves no purpose and clutters the code. It indicates confusion about the type of the expression, or that the code has been partially refactored.
This query applies to both the () operator and the as operator.
Recommendation¶
In all cases, the redundant cast should simply be removed.
Example¶
The following example shows a getter where the return value is explicitly cast to an int. However this is unnecessary because the type of the expression properties["Size"] is already int.
Dictionary<string, int> properties;
public int Size
{
get { return (int)properties["Size"]; }
}
The problem is resolved by deleting the useless (int).
Dictionary<string, int> properties;
public int Size
{
get { return properties["Size"]; }
}
References¶
MSDN, C# Programming Guide: Casting and Type Conversions.
Common Weakness Enumeration: CWE-561.